Skip to content

unwrap ret ty of iter::ArrayChunks::into_remainder #149127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2025
Merged

unwrap ret ty of iter::ArrayChunks::into_remainder #149127

merged 1 commit into from
Nov 21, 2025
+9 −9

Conversation

@bend-n
Copy link
Contributor

@bend-n bend-n commented Nov 20, 2025

changes iter::ArrayChunks::into_remainder to return array::IntoIter instead of Option<array::IntoIter> as suggested by @WaffleLapkin

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 mentioned this pull request Nov 20, 2025
Open
7 tasks
@tgross35
Copy link
Contributor

tgross35 commented Nov 20, 2025

This would need libs-api to take a look, I nominated #100450 for that.

@tgross35 tgross35 added S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2025
dtolnay
dtolnay approved these changes Nov 21, 2025
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

View changes since this review

@dtolnay dtolnay linked an issue Nov 21, 2025 that may be closed by this pull request
ArrayChunks::into_remainder does not return None when there is no remainder #116000
Closed
@dtolnay
Copy link
Member

dtolnay commented Nov 21, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 21, 2025

📌 Commit 68abe69 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 21, 2025
@dtolnay dtolnay assigned dtolnay and unassigned tgross35 Nov 21, 2025
@Zalathar Zalathar mentioned this pull request Nov 21, 2025
Merged
bors added a commit that referenced this pull request Nov 21, 2025
@bors
Auto merge of #149166 - Zalathar:rollup-fyrwtcb, r=Zalathar
e22dab3 
Rollup of 5 pull requests

Successful merges:

 - #148990 (Exhaustively specify names and stability of `--print` values)
 - #149127 (unwrap ret ty of `iter::ArrayChunks::into_remainder` )
 - #149134 (std: sys: net: uefi: Implement read_vectored)
 - #149135 (Constify `residual_into_try_type`)
 - #149160 (Check for intrinsic to fn ptr casts in unified coercions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f8bc31a into rust-lang:main Nov 21, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 21, 2025
rust-timer added a commit that referenced this pull request Nov 21, 2025
@rust-timer
Unrolled build for #149127
52ad945 
Rollup merge of #149127 - bend-n:iter_array_chunks_into_remainder_is_non_optional, r=dtolnay

unwrap ret ty of `iter::ArrayChunks::into_remainder`

changes [`iter::ArrayChunks::into_remainder`](#100450) to return `array::IntoIter` instead of `Option<array::IntoIter>` as suggested by [`@WaffleLapkin](https://github.com/rust-lang/rust/issues/100450#issuecomment-3555519025)`
@bors
Copy link
Collaborator

bors commented Nov 21, 2025

⌛ Testing commit 68abe69 with merge e22dab3...

@bend-n bend-n deleted the iter_array_chunks_into_remainder_is_non_optional branch November 21, 2025 07:14
@hkBst
Copy link
Member

hkBst commented Nov 21, 2025

See also #148249

@WaffleLapkin WaffleLapkin mentioned this pull request Nov 21, 2025
Closed
@Kobzol
Copy link
Member

Kobzol commented Nov 21, 2025

@bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

ArrayChunks::into_remainder does not return None when there is no remainder

7 participants

@bend-n @rustbot @tgross35 @dtolnay @bors @hkBst @Kobzol