-
Notifications
You must be signed in to change notification settings - Fork 14k
Remove context dependant ! fallback
#148871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WaffleLapkin
wants to merge
10
commits into
rust-lang:main
Choose a base branch
from
WaffleLapkin:never-simplifications
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
55621a1
remove support for context dependant `!` fallback
WaffleLapkin a75c857
doc fixes
WaffleLapkin 7735e5a
track never type fallback specifically
WaffleLapkin a137c21
remove an unnecessary negation
WaffleLapkin 60ade21
remove an outdated comment
WaffleLapkin 9bf596b
don't pass `self.<...>` as an argument to a method on the same type...
WaffleLapkin a7b102a
don't recompute diverging fallback type
WaffleLapkin 6b36e86
remove `feature(never_type_fallback)`
WaffleLapkin 31281eb
remove dead code
WaffleLapkin 39ac890
use a new tracking issue for never type changes
WaffleLapkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove an unnecessary negation
I think in this case the early return is harder to read than just an if. "if fallback hasn't occured we don't do..."
- Loading branch information
commit a137c21278cb3ed3b66102ed31e9518afa750840
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
existing, but I do not understand that comment?
Do you understand what this wants to say. It feels like this is a general "if fallback occurred, previously stalled goals may make progress again".
I really don't see how there's anything specific to opaques here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it either .-.
the example below is supposed to explain this, but I still don't get it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, want to rip this out and replace it with
even if this comment was somehow relevant, given that we both don't get what it means, I don't think it does us any good