-
Notifications
You must be signed in to change notification settings - Fork 14k
Implement AsRef<OsStr> for Cow<'_, Path>
#139432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
In rust-lang#31751, `impl AsRef<Path> for Cow<'_, OsStr>` was added, but the converse was omitted and it wasn't mentioned in discussion. This seems to have been a simple oversight, as it otherwise implemented traits mutually between `OsStr` and `Path`.
6e253cd to
781b92c
Compare
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
|
We'd need to do a crater run to check for inference failures. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
More inference failures—this time in external crates. |
|
What is the status of this? We can nominate for libs-api, but if this hit an issue in r-l/r as well as in one of our deps, I imagine the fallout vs. benefit ratio may be a bit on the high side. @rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
|
For the followup, |
In #31751,
impl AsRef<Path> for Cow<'_, OsStr>was added, but the converse was omitted and it wasn't mentioned in discussion. This seems to have been a simple oversight, as it otherwise implemented traits mutually betweenOsStrandPath.Tracked in #139429.
r? libs-api