Skip to content

Broaden reg-ex to all resolver variants #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2018
Merged

Broaden reg-ex to all resolver variants #7

merged 1 commit into from
May 30, 2018

Conversation

@katrinleinweber
Copy link
Contributor

@katrinleinweber katrinleinweber commented May 26, 2018

Hello :-)

The DOI foundation recommends this new, secure resolver. Accordingly, this PR updates the docu, reg-exes and tests.

Cheers!

@RichardLitt
Copy link
Member

RichardLitt commented May 30, 2018

Fantastic! Thank you, @katrinleinweber!

@RichardLitt RichardLitt merged commit 7e64e2d into regexhq:master May 30, 2018
@katrinleinweber
Copy link
Contributor Author

katrinleinweber commented May 30, 2018

You're welcome, and thanks for merging :-)

@RichardLitt
Copy link
Member

RichardLitt commented May 30, 2018

There's a failed test; I think it's probably unrelated? What do you think?

@katrinleinweber
Copy link
Contributor Author

katrinleinweber commented May 30, 2018

Ah, I think it's related. Best git revert 7e64e2dfdc96627a9e1d725fa0392709bed0d339 for now, in case the reason is not obvious.

RichardLitt added a commit that referenced this pull request May 30, 2018
@RichardLitt
Revert "Merge pull request #7 from katrinleinweber/support-preferred-…
a13ab60 
…resolver"

This reverts commit 7e64e2d, reversing
changes made to 5e4299a.
@RichardLitt
Copy link
Member

RichardLitt commented May 30, 2018

Reverted. Let me know if you'd like to submit a PR to fix it!

@katrinleinweber katrinleinweber mentioned this pull request Jul 15, 2018
Merged
katrinleinweber
katrinleinweber commented Jul 15, 2018
View reviewed changes
spec/test.js
]

var doiResolvePathWithoutProtocol = [
'dx.doi.org/10.1016/j.neuron.2014.09.004'
Copy link
Contributor Author

@katrinleinweber katrinleinweber Jul 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the error source: missing , :-D. Fixed in #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@katrinleinweber @RichardLitt