Skip to content

Conversation

@BenKanouse
Copy link

These missing parentheses were causing the string setting and text
setting to behave differently. I think that we really want the setting
to update the text data type when it is set.

Here is a simplified example of what was happening:

2.1.3 :006 > boolean = false
 => false
2.1.3 :007 > "good" || (boolean ? 'bad' : 'should never happen')
 => "good"
2.1.3 :008 > "good" || boolean ? 'bad' : 'should never happen'
 => "bad"

Test screenshots:
Red
screen shot 2017-02-07 at 4 21 43 pm

Green
screen shot 2017-02-07 at 4 22 42 pm

These missing parentheses were causing the string setting and text
setting to behave differently. I think that we really want the setting
to update the text data type when it is set.

Here is a simplified example of what was happening:
```
2.1.3 :006 > boolean = false
 => false
2.1.3 :007 > "good" || (boolean ? 'bad' : 'should never happen')
 => "good"
2.1.3 :008 > "good" || boolean ? 'bad' : 'should never happen'
 => "bad"
```
Copy link

@jcreed jcreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on this

@metaskills
Copy link
Member

Thanks! Just pushed simple fixes to v4.1.6 and v4.03.

@metaskills metaskills closed this Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants