Skip to content

Improve performance of view default function lookup #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Improve performance of view default function lookup #1073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions lib/active_record/connection_adapters/sqlserver/schema_statements.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,15 @@ def column_definitions(table_name)
view_exists = view_exists?(table_name)
view_tblnm = view_table_name(table_name) if view_exists

if view_exists
results = sp_executesql %{
SELECT c.COLUMN_NAME AS [name], c.COLUMN_DEFAULT AS [default]
FROM #{database}.INFORMATION_SCHEMA.COLUMNS c
WHERE c.TABLE_NAME = #{quote(view_tblnm)}
}.squish, "SCHEMA", []
default_functions = results.each.with_object({}) {|row, out| out[row["name"]] = row["default"] }.compact
end

sql = column_definitions_sql(database, identifier)

binds = []
Expand Down Expand Up @@ -402,13 +411,8 @@ def column_definitions(table_name)
ci[:default_function] = begin
default = ci[:default_value]
if default.nil? && view_exists
default = select_value %{
SELECT c.COLUMN_DEFAULT
FROM #{database}.INFORMATION_SCHEMA.COLUMNS c
WHERE
c.TABLE_NAME = '#{view_tblnm}'
AND c.COLUMN_NAME = '#{views_real_column_name(table_name, ci[:name])}'
}.squish, "SCHEMA"
view_column = views_real_column_name(table_name, ci[:name])
default = default_functions[view_column] if view_column.present?
end
case default
when nil
Expand Down