Be more strict when looking for the desired VS #56
Conversation
On systems where VS 2017 and VS 2019 are available, the starter script may choose VS 2019 if vc15 is requested. The documentation on vswhere isn't particularly clear regarding the -version parameter, but it states that a version range is expected. Therefore we change the shell setup script accordingly.
|
Example session on my machine: |
| set /a PHP_SDK_VS_RANGE=PHP_SDK_VS_NUM + 1 | ||
| set PHP_SDK_VS_RANGE="[%PHP_SDK_VS_NUM%,!PHP_SDK_VS_RANGE%!)" | ||
|
|
||
| for /f "tokens=1* delims=: " %%a in ('%~dp0\vswhere -nologo -version !PHP_SDK_VS_RANGE! -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath -format text') do ( |
There was a problem hiding this comment.
Great idea with the range. With this, the breaks are not needed in this loop, as it delivers just one result. Perhaps it would make sense to get rid of these breaks? The reason I rewrote it is that on my side the order was reversed - first 2017, then 2019. Now with your approach it seems to be consistent.
Thanks.
There was a problem hiding this comment.
Ah, yeah. I wonder what would happen if one has a preview and an RC installed side-by-side, though. In that case likely two installations will be found, i.e. two lines.
There was a problem hiding this comment.
Nope, preview is checked further down the line, attaching -prerelease to the command. Until vswhere changes behaviors, it should be ok.
Thanks.
These had been introduced to cater to multiple found VS installations, to only use the first one. Since the ranges are supposed to find only a single installation, and since apparently the order of multiple findings is not guaranteed, we remove the break constructs for better readability of the source code.
|
|
On systems where VS 2017 and VS 2019 are available, the starter script
may choose VS 2019 if vc15 is requested. The documentation on vswhere
isn't particularly clear regarding the -version parameter, but it
states that a version range is expected. Therefore we change the
shell setup script accordingly.