some minor improvements #42
Conversation
drop unused imports, unused variables, dirname(__FILE__) -> __DIR__, cs fixes, ...
|
|
| protected function setupDist() : void | ||
| { | ||
| $port = $this->getHttpPort(); | ||
| $host = $this->getHttpHost(); |
There was a problem hiding this comment.
Please keep these two calls where ever in the TrainingCaseHandler classes. The TrainingCaseHandler::init() needs to setup the server config, these calls will generate appropriate config items if not present. Some cases like Wordpress use a cli tool which needs this info, too. Cases like Symfony the tool doesn't need this however. Please check carefully to not to remove method calls as that might lead to bugs.
Thanks.
There was a problem hiding this comment.
Thank you, indeed, I did not notice. Can be rename these methods? Something like getOrMakeHttpPort/getOrInitHttpPort.
There was a problem hiding this comment.
Could rename, yep. Not critical.
Thanks.
|
Seems OK at first glance. Please also check the note. Thanks. |
|
Merged as 1b84734. Thanks! |
drop unused imports, unused variables,
dirname(__FILE__)->__DIR__, cs fixes, ...