Feature/string/add binary #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # src/main/scala/algorithms/array/Garage.scala # src/test/scala/algorithms/array/GarageTest.scala
kimxogus
requested changes
May 17, 2017
Owner
kimxogus
left a comment
There was a problem hiding this comment.
훌륭한 구현 감사합니다 👍
다만 몇가지 요청/의논 했으면 하는 점이 있는데, 코멘트 보시고 의견 부탁드려요 :)
| - [x] [MergeIntervals](src/main/scala/algorithms/array/MergeIntervals.scala) | ||
| - [x] [garage](src/main/scala/algorithms/array/Garage.scala) | ||
| - [longest_non_repeat](python/array/longest_non_repeat.py/) | ||
| - [merge_intervals](python/array/merge_intervals.py) |
Owner
There was a problem hiding this comment.
master 브랜치에 업데이트된 부분이 되돌아가있네요. 수정부탁드려요
| */ | ||
| println(calc(mutable.MutableList(1, 2, 3, 0, 4), List(0, 3, 2, 1, 4))) | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
기존의 구현이 잘못된 것이 아니라면 굳이 빼지 않고 새로운 구현을 추가해나가는 형태로 하는것이 어떨까 합니다.
Garage object 내에 함수를 다르게 두거나 같은 파일 내에 구현에 따라 object 파일을 따로 두는 방식으로 변경해주실 수 있나요?
또 main 함수의 코드는 테스트 목적으로 두신 것이라면 test 코드로 옮겨주시는것은 어떨까요?
kimxogus
reviewed
May 23, 2017
| */ | ||
| object LongestSubstring { | ||
|
|
||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
string/add binary 문제 풀이 추가했어요.
Related PRs or Issues
Related algorithms
Check List