Skip to content

Use for:else: where it makes sense #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Use for:else: where it makes sense #539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d69da2
refactoring code with For Else
idiomaticrefactoring Jan 22, 2022
7cd5c9e
Remove spurious empty lines
ambv Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions html5lib/_ihatexml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,18 +104,15 @@ def charStringToList(chars):
charRanges = [item.strip() for item in chars.split(" | ")]
rv = []
for item in charRanges:
foundMatch = False
for regexp in (reChar, reCharRange):
match = regexp.match(item)
if match is not None:
rv.append([hexToInt(item) for item in match.groups()])
if len(rv[-1]) == 1:
rv[-1] = rv[-1] * 2
foundMatch = True
break
if not foundMatch:
else:
assert len(item) == 1

rv.append([ord(item)] * 2)
rv = normaliseCharList(rv)
return rv
Expand Down