Drop support for EOL Python 2.7, 3.5 and 3.6 #536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR should be rediffed against current master. |
Contributor
Author
|
Updated against master! |
…SanitizerFile is deprecated.
Contributor
Author
|
Updated to fix this pytest deprecation warning: #529 (comment). |
Contributor
Author
|
Since this was opened 11 months ago, Python 3.6 has gone EOL and been dropped by pip, so dropping here too. |
Contributor
Author
|
Closing this year old PR, happy to re-open if any interest 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #541.
The readme says:
https://github.com/html5lib/html5lib-python#installation
pip supports:
https://pip.pypa.io/en/stable/installation/#compatibility
Therefore this PR drops support for EOL 2.7, 3.5 and 3.6 and upgrades to modern syntax using pyupgrade. There will be more cleanup possible, but I didn't want this PR to get too big.
Similarly, if you'd prefer a smaller PR, like dropping support and removing six, but keeping the older syntax for another PR, just let me know!