Working/relax email requirements #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2020 17:54
`git am` will accept patches which aren't fully RFC-compliant, as long as they start with `From` and have a `Subject` line. Relax PatchPatchHeader() so that it will accept such patches as well. Signed-off-by: George Dunlap <george.dunlap@citrix.com>
`git am` will tolerate patches of the form: ``` From: <foo@company.com> ``` In this case, the `Author` field will contain `foo@company.com <foo@company.com>`. Duplicate this behavior. Signed-off-by: George Dunlap <george.dunlap@citrix.com>
bluekeyes
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, last PR for a while.
git amis actually somewhat relaxed in what it accepts as far as email-looking things. There are two things I've encountered so far which go-gitdiff chokes on that git am accepts:git amwill accept a file which starts with theFrom:linegit amwill accept email-only "From" lines of the formFrom: <foo@company.com>.With these changes, everything works for my use case.