Skip to content

Update binary_search.cpp #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update binary_search.cpp #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update binary_search.cpp 
Made the algo work for a large value of low and high.
#hacktoberfest
  • Loading branch information
@satyamm5082000
satyamm5082000 authored Oct 11, 2020
commit cc8c62e2bc2d92efaa44b5833bdf6a3dcfee13f7
11 changes: 10 additions & 1 deletion Algorithms/searching/C++/binary_search.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@
using namespace std;

int binarySearch(const int value, const vector<int>& sortedVect, const int low, const int high) {
int mid = (low + high) / 2;
// int mid = (low + high) / 2;
/* Incase the value of low and high is large then
formula (low+high)/2 fails in some case ,
therefore it's better to use this formula:-

int mid = low + (high-low)/2;

*/

int mid = low + (high-low)/2;

if (value == sortedVect[mid])
return mid;
Expand Down