fix(ec2-alpha): allow publicly routable and 100.64.0.0/10 secondary cidr blocks with rfc 1918 primary #36151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
previously requested changes
Nov 22, 2025
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #36111.
Reason for this change
The
VpcV2validation incorrectly restricts secondary IPv4 CIDR blocks to only the same RFC 1918 range as the primary block. AWS VPC allows RFC 1918 primary + publicly routable secondary and RFC 1918 primary + 100.64.0.0/10 secondary combinations.Description of changes
validateIpv4addressto implement AWS VPC CIDR block rulesDescription of how you validated changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license