Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 20, 2025

Reason for this change

aws/aws-cdk-rfcs#824

CDK Mixins are composable, reusable abstractions that can be applied to any construct (L1, L2 or custom).
They are breaking down the traditional barriers between construct levels,
allowing customers to mix and match sophisticated features without being locked into specific implementations.

Description of changes

This PR makes the package public so it can be released. It also implements some small changes based on RFC feedback.
Main functional changes are:

  • Removing validate() in favor of just throwing errors
  • Making .with(), .apply() and .mustApply() variadic

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 20, 2025 20:23
@github-actions github-actions bot added the p2 label Nov 20, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 20, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mrgrain mrgrain added the pr/request-cli-integ-tests Request CLI integ tests to be run. You will need to review the code and approve the deployment. label Nov 20, 2025
@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 20, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 20, 2025 20:31

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrgrain mrgrain force-pushed the mrgrain/feat/mixins-preview branch from 09f50ef to ee79854 Compare November 21, 2025 10:24
@mrgrain mrgrain force-pushed the mrgrain/feat/mixins-preview branch from 55f2140 to a38c7a9 Compare November 21, 2025 10:59
@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Nov 21, 2025
@mrgrain mrgrain force-pushed the mrgrain/feat/mixins-preview branch from 5078e74 to ff69936 Compare November 21, 2025 14:41
@mrgrain mrgrain force-pushed the mrgrain/feat/mixins-preview branch from ff69936 to 5337f9d Compare November 21, 2025 17:04
@mrgrain mrgrain force-pushed the mrgrain/feat/mixins-preview branch from c07b989 to 4885670 Compare November 22, 2025 18:30
@mrgrain mrgrain force-pushed the mrgrain/feat/mixins-preview branch from 4885670 to d15ddd7 Compare November 23, 2025 11:53
@mrgrain mrgrain deployed to test-pipeline November 23, 2025 11:54 — with GitHub Actions Active
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@mrgrain mrgrain added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/do-not-merge This PR should not be merged at this time. labels Nov 23, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0c6ee1d into main Nov 23, 2025
28 of 31 checks passed
@mergify mergify bot deleted the mrgrain/feat/mixins-preview branch November 23, 2025 15:30
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr/request-cli-integ-tests Request CLI integ tests to be run. You will need to review the code and approve the deployment. pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants