-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Fix watermark alignment explanation in documentation #27227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-2.1
Are you sure you want to change the base?
Conversation
According to the following description, the flag should be false, then make sense.
|
this seems a duplicate of #27221 they both target 2.1. I suspect you intended one of these to target 2.2 |
| to disable split level watermark alignment to avoid fatal exceptions. | ||
|
|
||
| When setting the flag to true, watermark alignment will be only working properly when the number of splits/shards/partitions is equal to the | ||
| When setting the flag to false, watermark alignment will be only working properly when the number of splits/shards/partitions is equal to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add the Chinese version as well
davidradl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the Chinese version also
According to the following description, the flag should be false, then make sense.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation