This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Using scrollpoints with variables #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'd expect that the class would be toggled accordingly when the scrollpoint value changes. Right now you have to change the value and then scroll to have any effect on the class. Also please add demo and tests. And do not include a release in a PR. |
Contributor
Author
|
Fixed 👌 I also added a demo and a test. |
Contributor
|
Great, could you please squash commits into only one and force push ? Then i'll merge. |
Contributor
Author
|
Done ! |
PowerKiKi
added a commit
that referenced
this pull request
Nov 11, 2015
Using scrollpoints with variables
Contributor
|
Released as 1.2.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scrollpointcan be set using the directive scope option.This allows to change the scrollpoint using a variable.
Sample
You can change the value in the
inputand the scrollpoint will be updated if the entered value is valid.This is done with a
$watch()listener. I also changed the block that setsshift,absoluteandfixLimitto accept "absolute" values after render and the whole thing is wrapped into a function that is called whenever the$watch()event is fired.