Skip to content

Conversation

@joshkurz
Copy link
Contributor

@joshkurz joshkurz commented Jan 7, 2013

Added a calendar demo.
Updated the angular-ui submodule to the latest commit.
Updated angular.js to 1.0.3

@joshkurz
Copy link
Contributor Author

Cool to merge this?

@ProLoser
Copy link
Member

Is it not possible to make the fullcalendar lib a submodule instead of adding the code to this project?

@joshkurz
Copy link
Contributor Author

The fullcalendar repo does not have a build folder with current fullcalendar.js
files. If we can use the latest tag as a submodule then yes, but if not
then I would say no.

On Thu, Jan 10, 2013 at 6:02 PM, Dean Sofer notifications@github.comwrote:

Is it not possible to make the fullcalendar lib a submodule instead of
adding the code to this project?


Reply to this email directly or view it on GitHubhttps://github.com//pull/29#issuecomment-12123539.

Josh Kurz
http://dillingermediaonline.com/wordpresshttp://dillingermediaonline.com

@ProLoser
Copy link
Member

You can checkout tags in a submodule, yes. Submodules are for all intents and purposes full repos. However if the tag doesn't contain the build files as you describe then go ahead and merge it in as-is.

To checkout the tag, cd into the submodule, do a normal git checkout 'tagname' and then commit the submodule's sha1 state.

@joshkurz
Copy link
Contributor Author

The tags do contain the build files. I will make this edit then. I wasn't aware that we could use tags as the submodule.

@joshkurz
Copy link
Contributor Author

actually never mind. I thought that the unzipped tags contained the build dist folder, but it seems as if git ignores this folder completely. The only two places I know of to get the latest release of fullcalender.js is from http://arshaw.com/fullcalendar/download/ or to build on localhost with 'java make clean'.

ProLoser added a commit that referenced this pull request Jan 11, 2013
@ProLoser ProLoser merged commit 2f88648 into angular-ui:master Jan 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants