This repository was archived by the owner on Sep 25, 2025. It is now read-only.
chore: disallow relative path everywhere #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey 👋, thanks for trying to solve this issue! When I was saying "everywhere" it was only in the |
Collaborator
Author
Ohh I'll make sure only src is covered |
Contributor
Thanks! Sorry, I should have explained the issue better |
Deploying vue-ui with
|
| Latest commit: |
9c3a138
|
| Status: | 🚫 Build failed. |
Deploying vue-ui-playground with
|
| Latest commit: |
9c3a138
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82f4bf6b.vue-ui-playground.pages.dev |
| Branch Preview URL: | https://david-feature-130-disallow-r.vue-ui-playground.pages.dev |
Collaborator
Author
|
I reverted the changes related to relative paths on vitepress, removed the comment and I think the PR is ready to be reviewed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not used to setup aliases but I tried to follow what was already done in the project... some of the relative path replacements work as expected but these three files have imports which I have trouble with:
playground/src/main.ts.vitepress/theme/components/Changelog.vue.vitepress/theme/components/SidebarNavBefore.vueI added
// eslint-disable-next-line no-restricted-importsin those files (It's not the goal)@Barbapapazes I'd appreciate some guidance in this if possible 🙏🏻🙏🏻