-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add carousel component #127
feat: add carousel component #127
Conversation
|
I'm having trouble with running the tests Reading the logs I see the issue is related to embla-carousel, but as we are copying the components from Nuxt UI, It shouldn't require much changes I think.... Maybe you @Barbapapazes see something I don't 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a look to see why tests are failing.
Do they fail locally?
And you should add a demo.vue for the documentation!
Yes
My bad, I'll add it soon |
Deploying vue-ui-playground with
|
| Latest commit: |
985765d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d684b56.vue-ui-playground.pages.dev |
| Branch Preview URL: | https://david-feature-125-create-car.vue-ui-playground.pages.dev |
Deploying vue-ui with
|
| Latest commit: |
985765d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a775aee8.vue-ui.pages.dev |
| Branch Preview URL: | https://david-feature-125-create-car.vue-ui.pages.dev |
Hey 👋, I fix the issue. Actually, we simulate the DOM using jsdom (we could use happy-dom). These tools allow us to quickly run DOM tests without having to load a full browser but they only implement a subset of the DOM API. The issue you was facing was related to this. After search in the code of embla (https://github.com/davidjerleke/embla-carousel/blob/master/packages/embla-carousel/src/components/OptionsHandler.ts#L37), I see that |
|
Thanks for the fix and explanation @Barbapapazes 🙏🏻 |


Closes #125