Skip to content

Conversation

@sguest
Copy link
Contributor

@sguest sguest commented May 2, 2024

Add factorio-types

My own attempt at writing types for Factorio modding, which actually predates the one listed on the page now.

Add factorio-types
@Zamiell
Copy link
Contributor

Zamiell commented May 2, 2024

is one of them more complete and/or better maintained?

@sguest
Copy link
Contributor Author

sguest commented May 2, 2024

I'm obviously biased since I'm the creator of one, but I do believe mine (factorio-types) is better / more complete.

As far as maintained, I have actions that check for new versions of the Factorio API nightly, auto-build if a newer one exists, and push an updated package to the NPM repo once I approve the workflow.

@Zamiell
Copy link
Contributor

Zamiell commented May 2, 2024

@GlassBricks

@GlassBricks
Copy link
Contributor

GlassBricks commented May 2, 2024

I'm also biased since I'm the creator of the other, but I argue that mine is still much better. Many of the type features listed on the readme aren't present in factorio-types, typed-factorio includes a few lualib modules, includes the settings stage, and allows multiple stages to exist together.

I am interested in how you got the nightly version check to work, though. I'll likely implement that as well.

@lolleko
Copy link
Member

lolleko commented May 2, 2024

I see no issue in having both listed, especially because both are maintained.
I think the it's fine if we let the reader/user decide what to pick.

@lolleko lolleko merged commit 4ae2b0f into TypeScriptToLua:source May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants