-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Sections 1-3 #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pull-request-review-process
Are you sure you want to change the base?
Sections 1-3 #1693
Conversation
* Add new docs section for PR review guidelines * Include VuePress config file in the linting process * Include line numbers to code blocks in the docs * Update dependencies
|
@jverce is attempting to deploy a commit to the Pipedreamers Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). pipedream-docs-redirect-do-not-edit – ./docs🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs-redirect-do-not-edit/3AheWweZZfgq3Ftv57i4khzkm3n7 |
dylburger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jverce mostly small changes
Added docs for Common Files and Pagination are taken from [this PR](PipedreamHQ#1693) by jverce
* Add missing conventions & examples to Component Guidelines docs Added docs for Common Files and Pagination are taken from [this PR](#1693) by jverce * Add "getters" to .wordlist.txt * docs: Add guidelines for action name (omit article) * Formatting - surround package.json in backticks
Description
This is the first of a series of PR's that document the guidelines
to follow during a code review. It covers the following sections:
Code Changes