reflection.jl raises ArgumentError rather than a generic ErrorException #30568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han a generic ErrorException
…ther than a generic ErrorException
…ntError rather than a generic ErrorException
…ather than a generic ErrorException
…rather than a generic ErrorException
base/reflection.jl
Outdated
| ln = m.line | ||
| if ln <= 0 | ||
| error("could not determine location of method definition") | ||
| throw(ArgumentError("could not determine location of method definition")) |
Member
There was a problem hiding this comment.
👍 To most of these changes. I'm not sure this one is an argument error though; it doesn't really seem like the caller's fault.
Contributor
Author
There was a problem hiding this comment.
You are right. Not sure when we have this kind of case. Any suggestion for a more specific exception type rather than throwing a general ExceptionError?
Member
There was a problem hiding this comment.
Sometimes an ErrorException is the best fit, might be so here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be better to be specific about the type of an error when raising and handling exceptions.