Skip to content

Improve caching for failed class lookups #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve caching for failed class lookups #2912

wants to merge 1 commit into from

Conversation

@gharrma
Copy link
Contributor

@gharrma gharrma commented Dec 20, 2019 •
edited by abelkov
Loading

This slightly mitigates https://youtrack.jetbrains.com/issue/KT-35614, although it does
not fix the issue entirely.

Note: this speeds up findClass(), but not findClasses().

@gharrma
Improve caching for failed class lookups
d2a01b4 
This slightly mitigates KT-35614, although it does
not fix the issue entirely.

Note: this speeds up findClass(), but not findClasses().
@udalov udalov assigned dzharkov and unassigned udalov Jan 7, 2020
@dzharkov
Copy link
Contributor

dzharkov commented Jan 15, 2020

Sorry for the late reply, but I'm not sure about this change because this cache should not be used frequently when the requested class doesn't exist (as @udalov has mentioned in the comment).

I would appreciate it if you'd share some insights or pieces of evidence that it may help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dzharkov dzharkov

Labels

Compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gharrma @dzharkov @udalov @abelkov