-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Checkpoint Harmony and Email Collaboration Integration #20669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you! I've created an editorial review card for our team to review further. |
domalessi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback and suggestions. Give everything a look-through, and hit me up if you have questions. Ping me when the PR is ready for another look!
a63d4dd to
66332f1
Compare
|
Flagging for the team that I am the Docs Team reviewer for this PR, but that I will be OOTO next week and the following. I reviewed this a while back and left some feedback, but it appears that was not yet addressed. You can add |
I had already resolved the comments that you had given. I didn't mention that it was updated. Just to be safe, I did try to commit the suggestions, but it gave me the message saying "This suggestion has been applied or marked resolved". |
|
@deepakg-sacumen If you made changes, those changes do need to be committed before I review again. I marked my comments as "unresolved" just now which might allow you to apply your changes. You can either use the "Commit suggestion" button on each comment to commit my proposed change, or you can make changes on your end and commit those changes. Let me know when you've made these commits and then I can take another look. |
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
|
The following files, which will be shipped with the agent, were modified in this PR and You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label. List of modified files that will be shipped with the agent |
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
@domalessi , I have resolved the commits. Please review it again and let me know if any changes are required. |
domalessi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepakg-sacumen Just one remaining question about the Configuration section. Otherwise, looks good!
cp_harmony_ec/README.md
Outdated
| ### Configuration | ||
|
|
||
| **Configuring the Checkpoint Harmony Email and Collaboration platform to send logs to your S3 bucket** | ||
| - Refer to this [link][4] to more on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still confused about this section. It seems like the configuration instruction you have here is covered in Setup step 2 (Configure an [AWS S3 bucket to receive logs][3]), no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed this section.
domalessi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that final fix, @deepakg-sacumen ! Approved from my end.
What does this PR do?
This is an initial release PR of Checkpoint Harmony and Email Collaboration Firewall integration,n including all the required assets.
Motivation
This is a beta release of Agent-based integration and is intended for internal testing before going live.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged