Skip to content

Conversation

@deepakg-sacumen
Copy link
Contributor

What does this PR do?

This is an initial release PR of Checkpoint Harmony and Email Collaboration Firewall integration,n including all the required assets.

Motivation

This is a beta release of Agent-based integration and is intended for internal testing before going live.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@git-thuerk-done git-thuerk-done added the editorial review Waiting on a more in-depth review from a docs team editor label Jul 7, 2025
@git-thuerk-done
Copy link
Contributor

Thank you! I've created an editorial review card for our team to review further.

Copy link
Contributor

@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback and suggestions. Give everything a look-through, and hit me up if you have questions. Ping me when the PR is ready for another look!

@domalessi
Copy link
Contributor

Flagging for the team that I am the Docs Team reviewer for this PR, but that I will be OOTO next week and the following. I reviewed this a while back and left some feedback, but it appears that was not yet addressed. You can add Datadog/Documentation as a reviewer if you need this looked at while I'm gone. Otherwise, tag me (@domalessi ) when this is ready for another look from me!

@deepakg-sacumen
Copy link
Contributor Author

Flagging for the team that I am the Docs Team reviewer for this PR, but that I will be OOTO next week and the following. I reviewed this a while back and left some feedback, but it appears that was not yet addressed. You can add Datadog/Documentation as a reviewer if you need this looked at while I'm gone. Otherwise, tag me (@domalessi ) when this is ready for another look from me!

I had already resolved the comments that you had given. I didn't mention that it was updated. Just to be safe, I did try to commit the suggestions, but it gave me the message saying "This suggestion has been applied or marked resolved".

@domalessi
Copy link
Contributor

@deepakg-sacumen If you made changes, those changes do need to be committed before I review again. I marked my comments as "unresolved" just now which might allow you to apply your changes. You can either use the "Commit suggestion" button on each comment to commit my proposed change, or you can make changes on your end and commit those changes. Let me know when you've made these commits and then I can take another look.

deepakg-sacumen and others added 2 commits August 26, 2025 12:25
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
@github-actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent
cp_harmony_ec/datadog_checks/cp_harmony_ec/__about__.py
cp_harmony_ec/datadog_checks/cp_harmony_ec/__init__.py
cp_harmony_ec/datadog_checks/cp_harmony_ec/check.py
cp_harmony_ec/datadog_checks/cp_harmony_ec/config_models/__init__.py
cp_harmony_ec/datadog_checks/cp_harmony_ec/config_models/defaults.py
cp_harmony_ec/datadog_checks/cp_harmony_ec/config_models/instance.py
cp_harmony_ec/datadog_checks/cp_harmony_ec/config_models/shared.py
cp_harmony_ec/datadog_checks/cp_harmony_ec/config_models/validators.py
cp_harmony_ec/datadog_checks/cp_harmony_ec/data/conf.yaml.example
cp_harmony_ec/changelog.d/20669.added
cp_harmony_ec/pyproject.toml
cp_harmony_ec/hatch.toml

deepakg-sacumen and others added 6 commits August 26, 2025 12:25
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
@deepakg-sacumen
Copy link
Contributor Author

@deepakg-sacumen If you made changes, those changes do need to be committed before I review again. I marked my comments as "unresolved" just now which might allow you to apply your changes. You can either use the "Commit suggestion" button on each comment to commit my proposed change, or you can make changes on your end and commit those changes. Let me know when you've made these commits and then I can take another look.

@domalessi , I have resolved the commits. Please review it again and let me know if any changes are required.

Copy link
Contributor

@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakg-sacumen Just one remaining question about the Configuration section. Otherwise, looks good!

Comment on lines 18 to 21
### Configuration

**Configuring the Checkpoint Harmony Email and Collaboration platform to send logs to your S3 bucket**
- Refer to this [link][4] to more on this.
Copy link
Contributor

@domalessi domalessi Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still confused about this section. It seems like the configuration instruction you have here is covered in Setup step 2 (Configure an [AWS S3 bucket to receive logs][3]), no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this section.

Copy link
Contributor

@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that final fix, @deepakg-sacumen ! Approved from my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants