add a periodic upgrade check for ddev #20658

steveny91 · 2025-07-03T19:33:58Z

What does this PR do?

Periodically check pypi for new versions of ddev.

Config is on by default. But can be controlled with upgrade_check in the config toml file. It keeps track of this in a json file cache file. It saves the version and the date.

Logic goes:

See if file exist or if the last time it checked was 7 days ago or older
2a. If file doesn't exist or is older than 7 days, ping pypi to get latest version and right it to file
2b. if file exist and is not older than 7 days, read from the json file
3 If current version is older than the checked latest version, print out a message after every ddev command

Example:

ddev test ddev -fs
────────────────────────────────────────────────────────────────────────────────────────────────────────────────── ddev ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────
────────────────────────────────────────────────────────────────────────────────────────────────────────────────── lint ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────
cmd [1] | ruff format  --config ./pyproject.toml .
2 files reformatted, 225 files left unchanged
cmd [2] | ruff check --fix --config ./pyproject.toml .
src/ddev/cli/upgrade_check.py:57:27: G004 Logging statement uses f-string
   |
55 |                 atexit.register(exit_handler, app, msg)
56 |         except requests.RequestException as e:
57 |             logging.debug(f"Upgrade check failed: {e}")
   |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ G004
58 |     else:
59 |         if last_version < current_version:
   |

Found 2 errors (1 fixed, 1 remaining).
Some formatting errors are still found for which ruff has no fixes available. You would need to fix them manually.

!!An upgrade to version 12.0.0 is available for ddev. Your current version is 11.0.1.dev20!!

codecov · 2025-07-03T19:36:49Z

Codecov Report

❌ Patch coverage is 49.31507% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.17%. Comparing base (cb7659f) to head (4922e08).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
krakend	`?`
lustre	`?`
proxmox	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-09-18T15:02:48Z

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

steveny91 · 2025-11-20T19:22:06Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ddev/src/ddev/cli/upgrade_check.py

Review from lucia-sb is dismissed. Related teams and files:

agent-integrations
- ddev/src/ddev/cli/upgrade_check.py

steveny91 · 2025-11-20T20:20:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ddev/src/ddev/cli/upgrade_check.py

steveny91 · 2025-11-21T03:32:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ddev/src/ddev/config/model.py

steveny91 · 2025-11-21T17:53:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ddev/src/ddev/cli/upgrade_check.py

steveny91 · 2025-11-21T21:17:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ddev/src/ddev/cli/upgrade_check.py

steveny91 · 2025-11-21T21:27:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2025-11-21T21:33:44Z

ddev/src/ddev/cli/upgrade_check.py

+        except (requests.RequestException, OSError, json.JSONDecodeError, KeyError, InvalidVersion) as e:
+            logging.debug("Upgrade check failed: %s", e)
+            # Record the attempt to prevent even if failed
+            try:
+                write_last_run(current_version, date_now, cache_file)


Avoid discarding cached upgrade info on failure

If the PyPI request fails, the handler rewrites upgrade_check.json with the current version (lines 56-60). When a newer version was already cached, a transient network error will overwrite that information and reset the 7‑day timer, so users stop seeing upgrade notifications despite an update being known. Skipping the write on failure or preserving the previous cached version would avoid suppressing reminders after connectivity hiccups.

Useful? React with 👍 / 👎.

steveny91 · 2025-11-21T22:13:46Z

@codex review

chatgpt-codex-connector · 2025-11-21T22:21:29Z

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

add a periodic upgrade check for ddev

0e67f85

datadog-agent-integrations-bot bot added the ddev label Jul 3, 2025

steveny91 marked this pull request as ready for review July 3, 2025 19:34

steveny91 requested a review from a team as a code owner July 3, 2025 19:34

datadog-agent-integrations-bot bot added the team/agent-integrations label Jul 3, 2025

steveny91 added 2 commits July 3, 2025 15:54

lint

406f526

changelog

7d5fafe

lucia-sb previously approved these changes Jul 9, 2025

View reviewed changes

Merge branch 'master' into sy/ddev-check-upgrade

7579dd9

Merge branch 'master' into sy/ddev-check-upgrade

0b7999a

chatgpt-codex-connector bot reviewed Nov 20, 2025

View reviewed changes

ddev/src/ddev/cli/upgrade_check.py Outdated Show resolved Hide resolved

ddev/src/ddev/cli/upgrade_check.py Outdated Show resolved Hide resolved

add valueerror handling

0bcaabb

address codex comments

f270f48

chatgpt-codex-connector bot reviewed Nov 20, 2025

View reviewed changes

ddev/src/ddev/cli/upgrade_check.py Show resolved Hide resolved

error handling

eb94721

chatgpt-codex-connector bot reviewed Nov 21, 2025

View reviewed changes

ddev/src/ddev/config/model.py Outdated Show resolved Hide resolved

error handling

4d9a6c7

chatgpt-codex-connector bot reviewed Nov 21, 2025

View reviewed changes

ddev/src/ddev/cli/upgrade_check.py Show resolved Hide resolved

ctyle change

8b8efc9

chatgpt-codex-connector bot reviewed Nov 21, 2025

View reviewed changes

ddev/src/ddev/cli/upgrade_check.py Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Nov 21, 2025

View reviewed changes

nit

4922e08

add a periodic upgrade check for ddev #20658

Are you sure you want to change the base?

add a periodic upgrade check for ddev #20658

Conversation

steveny91 commented Jul 3, 2025

What does this PR do?

Uh oh!

codecov bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steveny91 commented Nov 20, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

steveny91 commented Nov 20, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

steveny91 commented Nov 21, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

steveny91 commented Nov 21, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

steveny91 commented Nov 21, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

steveny91 commented Nov 21, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

steveny91 commented Nov 21, 2025

Uh oh!

chatgpt-codex-connector bot commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jul 3, 2025 •

edited

Loading

github-actions bot commented Sep 18, 2025 •

edited

Loading