[FA] Always instrument methods #19956
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
77d942d to
49f035f
Compare
BaptisteFoy
approved these changes
Apr 7, 2025
iliakur
reviewed
Apr 29, 2025
Contributor
iliakur
left a comment
There was a problem hiding this comment.
Just some questions about the exception-catching logic in the new code we're introducing, otherwise seems fine!
iliakur
previously approved these changes
May 21, 2025
Contributor
iliakur
left a comment
There was a problem hiding this comment.
lgtm, but something's up with the CI...
iliakur
reviewed
May 27, 2025
Review from iliakur is dismissed. Related teams and files:
- agent-integrations
- datadog_checks_base/datadog_checks/base/utils/tracing.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR update the instrumentation logic of all the check methods.
Here are the following changes:
AGENT_CHECK_DEFAULT_TRACED_METHODSare always instrumented (meaning wrapped with atracer.trace)configure_tracermethod before running the method.configure_tracersamples all traces ifintegration_tracingorintegration_tracing_exhaustiveis truedd_trace_idanddd_parent_span_idif they exist in the instance.Next step is to read the sampling from the agent config, and let the agent pass the trade ID and the parent ID through the instance
Motivation
The goal is to be able to enable or disable tracing at runtime. (PR in progress)
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged