Skip to content

Conversation

@gulshan08091988
Copy link

@gulshan08091988 gulshan08091988 commented Jan 23, 2024

What does this PR do?

Adding Additional Statistics that are introduced in newer version of voltdb v11.

Motivation

To Keep the agent updates with product in newer versions

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

gulshan08091988 added a commit to gulshan08091988/integrations-core that referenced this pull request Jan 23, 2024
@github-actions
Copy link

github-actions bot commented Jan 23, 2024

Test Results

22 tests   18 ✅  34s ⏱️
 1 suites   1 💤
 1 files     2 ❌  1 🔥

For more details on these failures and errors, see this check.

Results for commit f145a14.

♻️ This comment has been updated with latest results.

@gulshan08091988
Copy link
Author

Test Results

22 tests   18 ✅  30s ⏱️  1 suites   1 💤  1 files     3 ❌

For more details on these failures, see this check.

Results for commit 78f2b1a.

♻️ This comment has been updated with latest results.

may i have feedback on the PR, why is it failing?

@FlorentClarret
Copy link
Member

Thanks for this PR! Could you please update the test so they assert the newly added metrics? Thanks a lot.

@gulshan08091988
Copy link
Author

gulshan08091988 commented Jan 29, 2024

Thanks for this PR! Could you please update the test so they assert the newly added metrics? Thanks a lot.

what version of voltdb datadog is using to run test on these metrics?
and why voltdb.memory.rss and voltdb.memory.index is not being collected? or throwing error.

@iliakur
Copy link
Contributor

iliakur commented Jan 31, 2024

@gulshan08091988 you can see which versions of voltdb we are testing with here. We go up until v10. After v9 we must build a custom image and host it ourselves. There was already 1 attempt to do this, but I didn't find the time to look into it.

Let me confer with my team to decide what to do about this. I appreciate your patience.

Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gulshan08091988 my earlier comment still holds.

@gulshan08091988
Copy link
Author

gulshan08091988 commented Feb 19, 2024

@gulshan08091988 my earlier comment still holds.

@iliakur Please share latest update.

@iliakur
Copy link
Contributor

iliakur commented Mar 11, 2024

@gulshan08091988 sorry about the delayed response.

The blocker here is the tests. As I mentioned earlier, we would have to build and host our custom image of voltdb for v11. Since we don't know how big of a challenge that is, we can't make commitments about delivery.

You're welcome to share some sort of Dockerfile to speed things up.

Thank you for your patience, apologies for the vague news.

@gulshan08091988
Copy link
Author

You're welcome to share some sort of Dockerfile to speed things up.

@iliakur thanks for the update, VoltDB Is Enterprise version and would require license to start the cluster. Do you have the valid license key to start the VoltDB cluster?

@iliakur
Copy link
Contributor

iliakur commented Mar 15, 2024

I can't find any license key, here is our custom Dockerfile for v10, and here is the docker-compose config that uses it (the variables are populated from this file).

@gulshan08091988
Copy link
Author

I can't find any license key, here is our custom Dockerfile for v10, and here is the docker-compose config that uses it (the variables are populated from this file).

We can provide you the software binary and temp license(3 days) once your setup will be ready to process the PR request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants