-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added New Statistics for VoltDB V11 #16690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test Results22 tests 18 ✅ 34s ⏱️ For more details on these failures and errors, see this check. Results for commit f145a14. ♻️ This comment has been updated with latest results. |
may i have feedback on the PR, why is it failing? |
|
Thanks for this PR! Could you please update the test so they assert the newly added metrics? Thanks a lot. |
what version of voltdb datadog is using to run test on these metrics? |
|
@gulshan08091988 you can see which versions of voltdb we are testing with here. We go up until v10. After v9 we must build a custom image and host it ourselves. There was already 1 attempt to do this, but I didn't find the time to look into it. Let me confer with my team to decide what to do about this. I appreciate your patience. |
iliakur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gulshan08091988 my earlier comment still holds.
@iliakur Please share latest update. |
|
@gulshan08091988 sorry about the delayed response. The blocker here is the tests. As I mentioned earlier, we would have to build and host our custom image of voltdb for v11. Since we don't know how big of a challenge that is, we can't make commitments about delivery. You're welcome to share some sort of Dockerfile to speed things up. Thank you for your patience, apologies for the vague news. |
@iliakur thanks for the update, VoltDB Is Enterprise version and would require license to start the cluster. Do you have the valid license key to start the VoltDB cluster? |
|
I can't find any license key, here is our custom Dockerfile for v10, and here is the docker-compose config that uses it (the variables are populated from this file). |
We can provide you the software binary and temp license(3 days) once your setup will be ready to process the PR request. |
What does this PR do?
Adding Additional Statistics that are introduced in newer version of voltdb v11.
Motivation
To Keep the agent updates with product in newer versions
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.