-
Notifications
You must be signed in to change notification settings - Fork 1.5k
attempt to support clusterAllReplicas for clickhouse datadog agent #14535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
yzhan289
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR!
I am yet to build/test locally.
You can build and test your changes using our CLI tool ddev. After installing ddev, you can spin up a test environment for clickhouse using ddev env start clickhouse <environment>. To see the possible ddev test environments we currently support, run ddev env ls clickhouse.
| tls_verify: Optional[bool] | ||
| use_global_custom_queries: Optional[str] | ||
| username: Optional[str] | ||
| clustername: Optional[str] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is autogenerated, so if you want to add clustername as a new configuration option, you can add it here, and then run ddev validate config clickhouse -s and ddev validate models clickhouse -s to regenerate this file and the conf.yaml.example file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, got it. let me try. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got bash-3.2$ ddev validate config clickhouse -s Validating default configuration files for 1 checks... Unsupported check: clickhouse or manifest_version: None
Hi there, I tried ddev, but got How may I set up the test environment for ClickHouse first? |
kayayarai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from docs
The most likely reason for that is that you didn't configure |
|
Hey @sichenzhao, did you get to try my tip above? Let us know if there is anything we can do to help you towards getting this into shape. |
What does this PR do?
#14199
Update clickhouse datadog agent client to have ability to specify a cluster name, and query system tables with clusterAllReplicas option.
Motivation
Datadog agent currently is not working with clickhouse clusters running across more than one node. This PR is an attempt to support monitoring multi-node clickhouse deployment by datadog agent.
Additional Notes
I am yet to build/test locally.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attachedqa/skip-qalabel.