[Feature] Show all callbacks on UI #16335
Open
+313
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
ishaan-jaff
reviewed
Nov 6, 2025
ishaan-jaff
reviewed
Nov 6, 2025
ishaan-jaff
requested changes
Nov 6, 2025
Contributor
ishaan-jaff
left a comment
There was a problem hiding this comment.
"generic" does not make sense here, what do you mean by that ?
Contributor
|
agreed with @ishaan-jaff re: "generic". I believe you mean "success + failure" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature] Show all callbacks on UI
Relevant issues
The current implementation of the UI only shows the success callbacks. It was hitting the /get/config/callbacks endpoint which was only querying for the success_callbacks. I modified the endpoint to include a
typefield that is either"success","failure", or"success_and_failure", depending on if the callback is defined in the"success_callbacks","failure_callbacks", or"callbacks"in the config.yaml. Callbacks added in the UI are success callbacks. I scoped it down to only allow modification of success callbacks in the UI (same as previous behavior)Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature
✅ Test
Changes
Screenshot