Numeric only Javascript form Validation?

Question

Can't seem to get this function to work for some reason, read about 10000 documents lol

Thanks!

So sorry, it's used to validate entries before submitting it to an sql database, with an alert — user2680550
– user2680550, Commented Nov 4, 2013 at 15:10
do you want just positive integers? positive and negative? floating point numbers as well? scientific notation? — Nzall
– Nzall, Commented Nov 4, 2013 at 15:10
I understand that. I meant, in your code on your page, how and where is that function called? — Pointy
– Pointy, Commented Nov 4, 2013 at 15:11
Change if(inputtxt.value.match(numbers)) to if(!numbers.test(inputtxt.value)) which will match non numbers — megawac
– megawac, Commented Nov 4, 2013 at 15:12

megawac · Accepted Answer · 2013-11-04 15:58:03Z

2

You just have a bit of poor logic with your if statement for numbers. As I mentioned in the comment

if(inputtxt.value.match(numbers)) should be

if(!numbers.test(inputtxt.value)) {
      alert('Please input numeric characters only');
      document.reasoning.mpn.focus();
      isValid = false;
}

For your document you're trying to validate fields with mpn name but you're not retrieving them as far as I can see. Seeing there is only 1 mpn field you may want to use an id so you dont have to iterate as below. Try the following:

isValid = isValid && all(document.getElementsByName("mpn"), function(ele) {
   if(numbers.test(ele.value)) {
       return true;
   } else {
       alert('Please input numeric characters only');
       ele.focus()
       return false;
   }
});

I don't feel like typing out the code for all but assume its something like _.all from underscorejs.

edited Nov 4, 2013 at 15:58

answered Nov 4, 2013 at 15:13

megawac

11.4k6 gold badges43 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user2680550 Over a year ago

Thank you very much Megawac for your response, i have updated the question with the code you supplied but for some reason it just submits the data without any warning (when entering non-numeric characters), thanks!

megawac Over a year ago

Does inputtxt refer to the correct element? Can you set up a jsfiddle if code continues not working

megawac Over a year ago

Updated but that fiddle doesnt work as the validateForm function is not defined when it's added to the input.

Collectives™ on Stack Overflow

Numeric only Javascript form Validation?

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related