Changing Javascript method to Jquery

Question

So I have the following Jquery calling a Javascript method

$j("a.Pinterest").attr("href", "javascript:void(addScript());");

And this is the Javascript Method

   function addScript() {
    var e = document.createElement('script');
    e.setAttribute('type', 'text/javascript');
    e.setAttribute('charset', 'UTF-8');
    e.setAttribute('src', 'http://assets.pinterest.com/js/pinmarklet.js?r=' + Math.random() * 99999999);
    return document.body.appendChild(e);
}

I was wondering if there was a way to have it all in Jquery ?

Have a look at the jQuery documentation: api.jquery.com/jQuery.getScript — Felix Kling
– Felix Kling, Commented Apr 13, 2012 at 15:47
Duplicates: stackoverflow.com/questions/4881164/…, stackoverflow.com/questions/9441142/…, stackoverflow.com/questions/5624366/…, stackoverflow.com/questions/4361033/jquery-load-script-on-click — Felix Kling
– Felix Kling, Commented Apr 13, 2012 at 15:48
Instead of injecting inline JavaScript with jQuery, use a jQuery click handler. — Sparky
– Sparky, Commented Apr 13, 2012 at 15:48

gen_Eric · Accepted Answer · 2012-04-13 15:55:13Z

1

$j("a.Pinterest").attr("href", "javascript:void(addScript());");

Please don't do this. I suggest using a click handler.

$j("a.Pinterest").click(addScript);

And then in your addScript you can use getScript to load the script.

function addScript(e) {
    e.preventDefault();
    $j.getScript('http://assets.pinterest.com/js/pinmarklet.js');
}

answered Apr 13, 2012 at 15:55

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Sparky Over a year ago

Finally. +1 for nuking that inline garbage.

StevieB Over a year ago

This works fine but how can I add the link cursor when hovering over the selected link

gen_Eric Over a year ago

@StevieB: You need to give it something as the href attribute. Try $j("a.Pinterest").attr("href", "#");, or add href="#" to the link in the HTML.

StevieB Over a year ago

Is this a good solution to ? $j("a.Pinterest").css('cursor', 'pointer');

Rick · Accepted Answer · 2012-04-13 15:48:21Z

1

http://api.jquery.com/jQuery.getScript/

$.getScript("http://assets.pinterest.com/js/pinmarklet.js")
    .done(function(script, textStatus) {
     console.log( textStatus );
 })

edit: I didn't try this, I just took your address and threw it in the getScript demo.

answered Apr 13, 2012 at 15:48

Rick

1,5739 silver badges11 bronze badges

Comments

Engineer · Accepted Answer · 2012-04-13 15:50:17Z

0

function addScript() {
      return $('<script/>',{
                          'type':'text/javascript',
                          'charset':'UTF-8',
                          'src':'http://assets.pinterest.com/js/pinmarklet.js?r=' + Math.random() * 99999999 
              }).appendTo("body")[0];
}

answered Apr 13, 2012 at 15:50

Engineer

48.9k12 gold badges90 silver badges93 bronze badges

Comments

mccow002 · Accepted Answer · 2012-04-13 15:51:58Z

0

You can create elements in jQuery using the $ selector.

$('<script></script>')

jQuery is also chainable, so you can have this:

$('<script></script>')
    .attr({
        'type' : 'text/javascript',
        'charset', 'UTF-8',
        'src' : 'http://assets.pinterest.com/js/pinmarklet.js?r=' + Math.random() * 99999999)
     })
     .appendTo(whatever)

If you're doing conditional script loading, you might want to take a look at the yepnope library.

I would question why you're dynamically added a script to the page on a button click. Seems like you would want the script ready and waiting for the user to click. If you're worried about load time, but the script tag at the bottom of the page to defer the loading.

answered Apr 13, 2012 at 15:51

mccow002

6,9343 gold badges28 silver badges37 bronze badges

1 Comment

StevieB Over a year ago

I just wanted to hide the href attribute from the mark up, since the mark up has to go into content editor for a cms and I didnt want users to mess with it

Collectives™ on Stack Overflow

Changing Javascript method to Jquery

4 Answers 4

4 Comments

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related