fix(zod): consider path-level parameters when generating zod schemas #2440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAPI permits parameters at the path object level and at the verb level. `generateZodRoute` only looks for parameters in the latter. Fix it to merge both levels. Reuse the parameters.yaml file in the hono test cases to catch the issue with tsc. Other code like the hono generator correctly generates imports for these *Params types, expecting the zod generator to emit them. The bug causes compilation to fail with "foo.ts has no exported member named barParams". Also reduce the number of optional chaining operators by null checking `spec` up front. generateZodRoute probably shouldn't proceed if the given path isn't in the API description. Signed-off-by: Alexandra Parker <alexandra.i.parker.civ@us.navy.mil>
melloware
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPI permits parameters at the path object level and at the verb level.
generateZodRouteonly looks for parameters in the latter. Fix it to merge both levels.Reuse the parameters.yaml file in the hono test cases to catch the issue with tsc. Other code like the hono generator correctly generates imports for these *Params types, expecting the zod generator to emit them. The bug causes compilation to fail with "foo.ts has no exported member named barParams".
Also reduce the number of optional chaining operators by null checking
specup front. generateZodRouteprobably shouldn't proceed if the given path isn't in the API description.