fix: don't mangle external URL $ref #2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
requested changes
Oct 15, 2025
It should be valid for a local file `target.yaml` to reference an external schema like GeoJSON. Preserve these URLs as-is and don't turn them into fake file paths. See: orval-labs#1557 Signed-off-by: Alexandra Parker <alexandra.i.parker.civ@us.navy.mil>
Collaborator
|
Thanks ! building and running tests now. great improvement! |
melloware
approved these changes
Oct 15, 2025
Contributor
Author
|
glad to be useful :) this is an awesome project tyvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be valid for a local file
target.yamlto reference an external schema like GeoJSON. Preserve these URLs as-is and don't turn them into fake file paths.Fix #1557