Skip to content

Conversation

@snebjorn
Copy link
Contributor

@snebjorn snebjorn commented Oct 12, 2025

This removes the last usages of legacy require paving the way for ESM

I had to bump the minimum required node version to 22.18.0. This is a breaking change.

Even though tests pass and no meaningful changes to samples were made, I doubt this will work for all users.

@melloware melloware added this to the 7.14.0 milestone Oct 12, 2025
@melloware
Copy link
Collaborator

Ok I marked this for 7.14.0

@melloware
Copy link
Collaborator

Actually if this is that major should it be 8.0.0?

@snebjorn
Copy link
Contributor Author

I added this to the orval package to make it clear that node 22.18.0 is the minimum.

"engines": {
  "node": ">=22.18.0"
},

I don't know what'll happen to bun and deno users. But we don't officially support those, right?

@melloware
Copy link
Collaborator

No i think all other package managers are "great if it works" and if people submit fixes we will accept them.

@melloware melloware merged commit 5c45f17 into orval-labs:master Oct 12, 2025
2 checks passed
@snebjorn snebjorn deleted the remove-require branch October 13, 2025 16:18
@melloware melloware added the enhancement New feature or request label Oct 19, 2025
@Noyabronok
Copy link
Contributor

Ok I marked this for 7.14.0

Per semver, breaking changes must get a major version bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants