Skip to content

Conversation

@aidanharan
Copy link
Contributor

Fix the following tests to accommodate the companies.status column that was added to the tests in Rails 7.0.5.

See https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/5122100848/jobs/9210694895?pr=1057

CalculationsTest#test_select_avg_with_joins_and_group_by_as_virtual_attribute_with_ar_coerced:
ActiveRecord::StatementInvalid: TinyTds::Error: Column 'companies.status' is invalid in the select list because it is not contained in either an aggregate function or the GROUP BY clause.

CalculationsTest#test_select_avg_with_joins_and_group_by_as_virtual_attribute_with_sql_coerced:
ActiveRecord::StatementInvalid: TinyTds::Error: Column 'companies.status' is invalid in the select list because it is not contained in either an aggregate function or the GROUP BY clause.

@aidanharan aidanharan marked this pull request as ready for review June 7, 2023 15:46
@aidanharan aidanharan merged commit 288ceea into main Jun 7, 2023
@aidanharan aidanharan deleted the fix-tests-companies-status branch June 7, 2023 15:46
lavika pushed a commit to lavika/activerecord-sqlserver-adapter that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants