Skip to content

gh-103693: Add convenience variable feature to pdb #103694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 3, 2023
Merged

gh-103693: Add convenience variable feature to pdb #103694

merged 7 commits into from
May 3, 2023

Conversation

@gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Apr 22, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Apr 22, 2023
Closed
@gaogaotiantian
Copy link
Member Author

gaogaotiantian commented May 1, 2023

Hi @iritkatriel , do you think you could give this a review so it can make 3.12?

iritkatriel
iritkatriel reviewed May 1, 2023
View reviewed changes
@iritkatriel
Copy link
Member

iritkatriel commented May 1, 2023

This needs to be mentioned in "what's new in 3.12" as well.

@gaogaotiantian
Copy link
Member Author

gaogaotiantian commented May 1, 2023

This needs to be mentioned in "what's new in 3.12" as well.

Should I do this in this PR or it's something that should be taken care of later?

@iritkatriel
Copy link
Member

iritkatriel commented May 1, 2023

This needs to be mentioned in "what's new in 3.12" as well.

Should I do this in this PR or it's something that should be taken care of later?

In this PR.

gaogaotiantian and others added 2 commits May 1, 2023 15:31
@gaogaotiantian @iritkatriel
Update Doc/library/pdb.rst
ac23148 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@gaogaotiantian
Update docs and whatsnew
150250b
@gaogaotiantian
Copy link
Member Author

gaogaotiantian commented May 1, 2023

I added the whatsnew entry but not sure if that's good. There's no new function added so I did not link anything.

iritkatriel
iritkatriel reviewed May 1, 2023
View reviewed changes
@iritkatriel
Copy link
Member

iritkatriel commented May 1, 2023

I added the whatsnew entry but not sure if that's good. There's no new function added so I did not link anything.

@CAM-Gerlach any advice or shall we leave it as is?

iritkatriel
iritkatriel reviewed May 1, 2023
View reviewed changes
@gaogaotiantian @iritkatriel
Update Doc/library/pdb.rst
f626d36 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@iritkatriel iritkatriel merged commit 0fc58c6 into python:main May 3, 2023
@erlend-aasland erlend-aasland mentioned this pull request May 3, 2023
Merged
@gaogaotiantian gaogaotiantian deleted the pdb-convenience-variable branch May 4, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaogaotiantian @iritkatriel @bedevere-bot