Skip to content

Conversation

@thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented May 29, 2024

This PR should:

  1. Update GH Actions to use Node 20 - the Firebase CLI no longer supports Node 16.
  2. Update GH Actions to use Ubuntu instead of MacOS.
    The latest MacOS runner in GH Actions uses arm64 arch instead of x86_64, thus the android-emulator-runner action can't start an Android emulator.
    Ubuntu is said to be faster according to the android-emulator-runner action README and they also recommend enabling KVM.
  3. Change the Android applicationId to com.example.firebase_snippets_app, which is the name expected by CI to clean up once the tests have finished running.
  4. Disable animations on the Android device to make tests run faster.
  5. Remove the github_sign_in flutter package which is unmaintained for ~3 years and not really being used in the project.

@thatfiredev thatfiredev marked this pull request as ready for review May 29, 2024 23:51
@thatfiredev thatfiredev requested a review from nohe427 May 29, 2024 23:53
@thatfiredev thatfiredev merged commit 2d9d956 into main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants