Skip to content

feat: promisify ses.clearHostResolverCache() #17229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2019
Merged

feat: promisify ses.clearHostResolverCache() #17229

merged 1 commit into from
Mar 8, 2019

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Mar 5, 2019

Description of Change

Promisifies ses.clearHostResolverCache().

Checklist

Release Notes

Notes: Converted session.clearHostResolverCache() to return a Promise instead of taking a callback.

@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Mar 5, 2019
miniak
miniak requested changes Mar 6, 2019
View reviewed changes
@codebytere codebytere changed the title feat: promisify ses.clearHostResolverCache() [wip] feat: promisify ses.clearHostResolverCache() Mar 6, 2019
@codebytere codebytere changed the title [wip] feat: promisify ses.clearHostResolverCache() feat: promisify ses.clearHostResolverCache() Mar 6, 2019
@codebytere codebytere removed the wip ⚒ label Mar 6, 2019
@codebytere codebytere force-pushed the promisify-session-hostresolver branch from 069b12e to 03553b1 Compare March 7, 2019 07:51
@codebytere codebytere requested a review from miniak March 7, 2019 15:53
@codebytere codebytere force-pushed the promisify-session-hostresolver branch from 7713ba6 to 2c8e57e Compare March 8, 2019 04:36
@codebytere codebytere added the semver/minor backwards-compatible functionality label Mar 8, 2019
deepak1556
deepak1556 approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with style change.

@codebytere codebytere force-pushed the promisify-session-hostresolver branch from 2c8e57e to b31c209 Compare March 8, 2019 15:58
@codebytere codebytere force-pushed the promisify-session-hostresolver branch from b31c209 to ac0b9ab Compare March 8, 2019 17:06
@codebytere codebytere force-pushed the promisify-session-hostresolver branch from ac0b9ab to a606d40 Compare March 8, 2019 17:08
@codebytere codebytere merged commit e5e6aa2 into master Mar 8, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 8, 2019

Release Notes Persisted

Converted session.clearHostResolverCache() to return a Promise instead of taking a callback.

@codebytere codebytere deleted the promisify-session-hostresolver branch March 8, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@miniak miniak miniak approved these changes

Assignees

No one assigned

Labels

semver/minor backwards-compatible functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere @deepak1556 @miniak