Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

BaseObject.fromJSON #25

Merged
merged 3 commits into from
Jun 25, 2015
Merged

BaseObject.fromJSON #25

merged 3 commits into from
Jun 25, 2015

Conversation

@stryju
Copy link
Contributor

@stryju stryju commented Jun 24, 2015

  • adds and uses BaseObject.fromJSON BaseObject.new
  • cleans up tabs, spaces, semicolons
  • sprinkles some es6 on top

@stryju
- adds and uses BaseObject.fromJSON
6390614 
- cleans up tabs, spaces, semicolons
- sprinkles some es6 on top
@stryju stryju changed the title - adds and uses BaseObject.fromJSON BaseObject.fromJSON Jun 24, 2015
@ProLoser
Copy link
Member

ProLoser commented Jun 24, 2015

Honestly I didn't use => EVERYWHERE because I thought I read somewhere that it shouldn't be needlessly abused (ie: non-callback situations)

ProLoser
ProLoser reviewed Jun 24, 2015
View reviewed changes
modules/Authentication/Authenticated.js
Copy link
Member

@ProLoser ProLoser Jun 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this will get parsed properly?

Copy link
Contributor Author

@stryju stryju Jun 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite sure :)

ProLoser
ProLoser reviewed Jun 25, 2015
View reviewed changes
modules/Authentication/Authenticated.js
Copy link
Member

@ProLoser ProLoser Jun 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a class, this syntax won't work I don't think in the middle of a simple hash object.

Copy link
Member

@ProLoser ProLoser Jun 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM just learned this works and is kickass

ProLoser added a commit that referenced this pull request Jun 25, 2015
@ProLoser
Merge pull request #25 from stryju/feature/from-json
2d44ddf 
BaseObject.fromJSON
@ProLoser ProLoser merged commit 2d44ddf into angular-ui:master Jun 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stryju @ProLoser