Skip to content

Improve JSX documentation #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 9, 2021
Merged

Improve JSX documentation #65

merged 5 commits into from
Aug 9, 2021

Conversation

@GlassBricks
Copy link
Contributor

@GlassBricks GlassBricks commented Aug 9, 2021

Notes:

  • TSX is just the name of the file extension, the syntax is still called JSX (like in here: https://www.typescriptlang.org/docs/handbook/jsx.html). Links may need to be updated for this (in changelog/release notes).
  • Added section on creating your own JSX, and the caveats of that.

GlassBricks added a commit to GlassBricks/TypeScriptToLua that referenced this pull request Aug 9, 2021
@GlassBricks
Change TSX to JSX in changelog
6bfe097 
See TypeScriptToLua/TypeScriptToLua.github.io#65
@GlassBricks GlassBricks mentioned this pull request Aug 9, 2021
Merged
Perryvw
Perryvw reviewed Aug 9, 2021
View reviewed changes
GlassBricks and others added 2 commits August 9, 2021 12:39
@GlassBricks @Perryvw
Update docs/jsx.md
95156be 
Co-authored-by: Perry van Wesel <Perryvw@users.noreply.github.com>
@GlassBricks @Perryvw
Update docs/jsx.md
a6ec1b1 
Co-authored-by: Perry van Wesel <Perryvw@users.noreply.github.com>
@GlassBricks GlassBricks closed this Aug 9, 2021
@GlassBricks GlassBricks reopened this Aug 9, 2021
GlassBricks and others added 2 commits August 9, 2021 12:40
@GlassBricks @Perryvw
Update docs/jsx.md
471e598 
Co-authored-by: Perry van Wesel <Perryvw@users.noreply.github.com>
@GlassBricks
Changes for PR.
2f9d177
@Perryvw Perryvw merged commit 550769f into TypeScriptToLua:source Aug 9, 2021
Perryvw pushed a commit to TypeScriptToLua/TypeScriptToLua that referenced this pull request Aug 9, 2021
@GlassBricks
Change TSX to JSX in changelog (#1077)
d2d5ece 
See TypeScriptToLua/TypeScriptToLua.github.io#65

Co-authored-by: Benjamin Ye <24237065+enjoydambience@users.noreply.github.com>
sanikoyes pushed a commit to sanikoyes/TypeScriptToLua that referenced this pull request Sep 24, 2021
@GlassBricks @sanikoyes
Change TSX to JSX in changelog (TypeScriptToLua#1077)
67c367d 
See TypeScriptToLua/TypeScriptToLua.github.io#65

Co-authored-by: Benjamin Ye <24237065+enjoydambience@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Perryvw Perryvw Perryvw left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GlassBricks @Perryvw