Update self parameter information #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ark120202
reviewed
Nov 11, 2020
docs/faq/the-self-parameter.md
Outdated
|
|
||
| ## Removing it | ||
|
|
||
| ### `noImplicitSelf` |
Contributor
There was a problem hiding this comment.
I think we should leave it as the last option, since more likely users would want to disable this behavior for Lua declarations, which are generally not affected by noImplicitSelf
Comment on lines
11
to
13
| Telling TypeScript not to allow `this` to be used will eliminate that parameter from its containing context. | ||
|
|
||
| Other workarounds are available for removing this too. |
Contributor
There was a problem hiding this comment.
It would be nice to mention that disabling it should be done only when it's required for interop, but not for regular code
sidebars.json
Outdated
| }, | ||
| { | ||
| "type": "category", | ||
| "label": "FAQ", |
Contributor
There was a problem hiding this comment.
Do you think we'll have more FAQ in the future? If we don't, I think it could be a top-level page, probably after "caveats" in the sidebar
Contributor
Author
There was a problem hiding this comment.
I think we might, but good idea to keep it top level for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I'd take a look at this page since self parameter questions are the most common questions we get
Some users might look for an FAQ section before asking
docs/advanced/functions-and-the-self-parametertodocs/the-self-parameternoImplicitSelfAssignment Errorssection to describe the error as being an incompatibility between two typesAssignment Errorsto quote the errors instead of having them in code comments