Skip to content

Conversation

@devongleeson
Copy link
Contributor

No description provided.

@Jolanrensen Jolanrensen changed the base branch from release to main July 21, 2023 09:53
@Jolanrensen
Copy link
Collaborator

Jolanrensen commented Jul 21, 2023

Awesome! I suppose an update to 3.3.2 from 3.3.1 won't cause many issues. I did change your PR to target main instead of release, as that's common for this project.

Please also update gradles.properties to Spark 3.3.2 as the project always targets the latest possible Spark version by default. Same with the integration examples. I see you found a couple of versions that we forgot to update, thanks :)

I'll try and run the github actions that will perform the tests in a bit :)

Edit: the tests seem to work :)

@Jolanrensen Jolanrensen modified the milestones: 1.2.3, 1.2.4 Jul 21, 2023
@Jolanrensen Jolanrensen added the dependencies Pull requests that update a dependency file label Jul 21, 2023
@devongleeson
Copy link
Contributor Author

devongleeson commented Jul 21, 2023

Question: should this be updated? https://github.com/Kotlin/kotlin-spark-api/blob/release/core/build.gradle.kts#L30

Looks like that logic lives in a few places in the project's build.

@Jolanrensen
Copy link
Collaborator

Question: should this be updated? https://github.com/Kotlin/kotlin-spark-api/blob/release/core/build.gradle.kts#L30

Looks like that logic lives in a few places in the project's build.

Looks like the tests pass for 3.3.2, so it seems that Spark fixed the issue. I do suspect the issue is still present for 3.3.1, so it can remain like that.

@Jolanrensen Jolanrensen self-requested a review July 24, 2023 10:56
@Jolanrensen
Copy link
Collaborator

Thanks for the help! I'll probably publish 1.2.4 soon with spark 3.3.2 support and java 8 support for jupyter notebooks.

@Jolanrensen Jolanrensen merged commit 40d1d46 into Kotlin:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants