➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-01-05 11:33 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 17828 | merged | serhiy.storchaka, 2020-01-11 10:51 | |
| PR 18479 | merged | miss-islington, 2020-02-12 10:17 | |
| Messages (5) | |||
|---|---|---|---|
| msg359331 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2020-01-05 11:33 | |
SyntaxError can be raised at different stages of compiling. In some places the source text is not available and should be read from the file using the file name. Which does not work in case of compiling a string or reading from stdin.
>>> 0z
File "<stdin>", line 1
0z
^
SyntaxError: invalid syntax
>>> 0xz
File "<stdin>", line 1
SyntaxError: invalid hexadecimal literal
In the second example above the source line and the caret are absent in REPL.
The proposed PR fixes two errors in raising a SyntaxError in the tokenizer.
1. The text of the source line was not set if an exception was raised in the tokenizer. Since most of these exceptions (with more detailed description) were added in 3.8 I consider this a regressions.
2. The offset attribute was an offset in bytes. Now it is an offset in characters.
It only fixes errors in the tokenizer. There are similar bugs in other parts of the compiler.
This issue is based on the article https://aroberge.blogspot.com/2019/12/a-tiny-python-exception-oddity.html .
|
|||
| msg359769 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2020-01-10 23:29 | |
On entry of '0xz', IDLE from 3.6 to date highlights the '0x' part of the original entry. I presume it can do this because it ignores the text attribute, and because bytes == chars for at least '0x'. The 'proposed PR' is not listed here. Is it not yet submitted, or is the issue number wrong? |
|||
| msg359791 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2020-01-11 10:59 | |
Sorry, wrong issue number. |
|||
| msg361873 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2020-02-12 10:17 | |
New changeset 0cc6b5e559b8303b18fdd56c2befd900fe7b5e35 by Serhiy Storchaka in branch 'master': bpo-39219: Fix SyntaxError attributes in the tokenizer. (GH-17828) https://github.com/python/cpython/commit/0cc6b5e559b8303b18fdd56c2befd900fe7b5e35 |
|||
| msg361875 - (view) | Author: miss-islington (miss-islington) | Date: 2020-02-12 10:35 | |
New changeset efd878cdb46d9c7038d93fb36eb1ff7dc5baf9ec by Miss Islington (bot) in branch '3.8': bpo-39219: Fix SyntaxError attributes in the tokenizer. (GH-17828) https://github.com/python/cpython/commit/efd878cdb46d9c7038d93fb36eb1ff7dc5baf9ec |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:24 | admin | set | github: 83400 |
| 2020-02-12 10:57:48 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2020-02-12 10:35:14 | miss-islington | set | nosy:
+ miss-islington messages: + msg361875 |
| 2020-02-12 10:17:14 | miss-islington | set | pull_requests: + pull_request17849 |
| 2020-02-12 10:17:07 | serhiy.storchaka | set | messages: + msg361873 |
| 2020-01-11 10:59:53 | serhiy.storchaka | set | messages: + msg359791 |
| 2020-01-11 10:51:31 | serhiy.storchaka | set | keywords:
+ patch stage: patch review pull_requests: + pull_request17360 |
| 2020-01-10 23:29:00 | terry.reedy | set | nosy:
+ terry.reedy messages: + msg359769 |
| 2020-01-05 11:33:45 | serhiy.storchaka | create | |