Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rasbt/LLMs-from-scratch
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: rasbt/LLMs-from-scratch
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: qwen-tokenizer-fix
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 6 files changed
  • 2 contributors

Commits on Sep 15, 2025

  1. prevent self.apply_chat_template being applied for base Qwen models

    @casinca
    casinca committed Sep 15, 2025
    Configuration menu
    Copy the full SHA
    df50439 View commit details
    Browse the repository at this point in the history

  2. - added no chat template comparison in test_chat_wrap_and_equivalence 

    - removed duplicate comparison
    @casinca
    casinca committed Sep 15, 2025
    Configuration menu
    Copy the full SHA
    3a5ee8c View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2025

  1. Merge branch 'main' into qwen-tokenizer-fix

    @casinca
    casinca authored Sep 16, 2025
    Configuration menu
    Copy the full SHA
    701b5ad View commit details
    Browse the repository at this point in the history

  2. Revert "- added no chat template comparison in `test_chat_wrap_and_eq… 

    …uivalence`"

This reverts commit 3a5ee8c.
    @casinca
    casinca committed Sep 16, 2025
    Configuration menu
    Copy the full SHA
    02a1cb1 View commit details
    Browse the repository at this point in the history

  3. Revert "prevent self.apply_chat_template being applied for base Qwe… 

    …n models"

This reverts commit df50439.
    @casinca
    casinca committed Sep 16, 2025
    Configuration menu
    Copy the full SHA
    186e83c View commit details
    Browse the repository at this point in the history

  4. copied download_file in utils from https://github.com/rasbt/reaso… 

    …ning-from-scratch/blob/main/reasoning_from_scratch/utils.py
    @casinca
    casinca committed Sep 16, 2025
    Configuration menu
    Copy the full SHA
    4ea2fb4 View commit details
    Browse the repository at this point in the history

  5. added copy of test def test_tokenizer_equivalence() from `reasoning… 

    …-from-scratch` in `test_qwen3.py`
    @casinca
    casinca committed Sep 16, 2025
    Configuration menu
    Copy the full SHA
    16f30a0 View commit details
    Browse the repository at this point in the history

  6. removed duplicate code fragment intest_chat_wrap_and_equivalence

    @casinca
    casinca committed Sep 16, 2025
    Configuration menu
    Copy the full SHA
    8237b3f View commit details
    Browse the repository at this point in the history

  7. use apply_chat_template

    @rasbt
    rasbt committed Sep 16, 2025
    Configuration menu
    Copy the full SHA
    862df48 View commit details
    Browse the repository at this point in the history
Loading