Fix quoting of non-national columns.

Author: metaskills

CHANGELOG.md

@@ -3,6 +3,7 @@
 #### Fixed
 
 * Removed errand puts statment from database tasks.
+* Fix quoting of non-national columns.
 
 
 ## v4.2.14

lib/active_record/connection_adapters/sqlserver/type/char.rb

@@ -21,7 +21,7 @@ def initialize(value)
             end
 
             def quoted
-              "'#{@value}'"
+              "'#{Utils.quote_string(@value)}'"
             end
 
             def to_s

test/cases/specific_schema_test_sqlserver.rb

@@ -125,6 +125,16 @@ def quoted_id
     assert_sql(/@0 = 'T'/) { SSTestDatatypeMigration.where(varchar_col: 'T').first }
   end
 
+  it 'can update and hence properly quoted non-national char/varchar columns' do
+    o = SSTestDatatypeMigration.create!
+    o.varchar_col = "O'Reilly"
+    o.save!
+    o.reload.varchar_col.must_equal "O'Reilly"
+    o.varchar_col = nil
+    o.save!
+    o.reload.varchar_col.must_be_nil
+  end
+
   # With column names that have spaces
 
   it 'create record using a custom attribute reader and be able to load it back in' do