Added savepoint name param to create_savepoint, release_savepoint and rollback_to_savepoint

Author: wbond

lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -56,15 +56,15 @@ def rollback_db_transaction
           do_execute 'IF @@TRANCOUNT > 0 ROLLBACK TRANSACTION'
         end
 
-        def create_savepoint
-          disable_auto_reconnect { do_execute "SAVE TRANSACTION #{current_savepoint_name}" }
+        def create_savepoint(name = current_savepoint_name)
+          disable_auto_reconnect { do_execute "SAVE TRANSACTION #{name}" }
         end
 
-        def release_savepoint
+        def release_savepoint(name = current_savepoint_name)
         end
 
-        def rollback_to_savepoint
-          disable_auto_reconnect { do_execute "ROLLBACK TRANSACTION #{current_savepoint_name}" }
+        def rollback_to_savepoint(name = current_savepoint_name)
+          disable_auto_reconnect { do_execute "ROLLBACK TRANSACTION #{name}" }
         end
 
         def add_limit_offset!(_sql, _options)

test/cases/transaction_test_sqlserver.rb

@@ -46,3 +46,19 @@ def assert_no_ships
 
 end
 
+class TransactionTest < ActiveRecord::TestCase
+  include SqlserverCoercedTest
+
+  COERCED_TESTS = [:test_releasing_named_savepoints]
+
+  def test_coerced_releasing_named_savepoints
+    Topic.transaction do
+      Topic.connection.create_savepoint("another")
+      Topic.connection.release_savepoint("another")
+
+      # The origin rails test tries to re-release the savepoint, but
+      # since sqlserver doesn't have the concept of releasing, it doesn't
+      # fail, so we just omit that part here
+    end
+  end
+end