feat: get terminal test to working state

Author: jsjoeio

test/e2e/models/CodeServer.ts

@@ -92,12 +92,17 @@ export class CodeServer {
   }
 
   async focusTerminal() {
-    // TODO@jsjoeio combine viewTerminal and focusTerminal
-    // check if terminal is open before hitting keyboard shortcut
-    // otherwise it will close it
-    await this.page.keyboard.press("Control+Backquote")
-    // Give the terminal a second to load, change shells, etc.
-    await this.page.waitForTimeout(1500)
+    // Open using the manu
+    // Click [aria-label="Application Menu"] div[role="none"]
+    await this.page.click('[aria-label="Application Menu"] div[role="none"]')
+
+    // Click text=View
+    await this.page.hover("text=View")
+    await this.page.click("text=View")
+
+    // Click text=Terminal
+    await this.page.hover("text=Terminal")
+    await this.page.click("text=Terminal")
   }
 
   async quickOpen(input: string) {

test/e2e/terminal.test.ts

@@ -40,6 +40,8 @@ test.describe("Integrated Terminal", () => {
     // await codeServer.viewTerminal()
     await codeServer.focusTerminal()
 
+    // give the terminal a second to load
+    await page.waitForTimeout(3000)
     await page.keyboard.type(`echo '${testString}' > ${tmpFile}`)
     // Wait for the typing to finish before hitting enter
     await page.waitForTimeout(500)
@@ -51,8 +53,13 @@ test.describe("Integrated Terminal", () => {
     // resolve to undefined
     // If the promise rejects (i.e. the file doesn't exist)
     // then the assertion will fail
-    expect(fs.promises.access(tmpFile)).resolves.toBeUndefined()
+    await expect(fs.promises.access(tmpFile)).resolves.toBeUndefined()
 
-    // TODO delete tmpFolder
+    await fs.promises.rmdir(tmpFolderPath, { recursive: true })
+    // Make sure neither file nor folder exist
+    // @ts-ignore
+    expect(fs.promises.access(tmpFile)).rejects.toThrowError(/no such file or directory/)
+    // @ts-ignore
+    expect(fs.promises.access(tmpFolderPath)).rejects.toThrowError(/no such file or directory/)
   })
 })