fix: extend Services class with CodeIgniter's BaseService (#198)

* fix: extend Services class with CodeIgniter's BaseService

* chore: remove BooleanInIfConditionRuleFixerRector rector rule + run cs-fix

Author: yassinedoghri

rector.php

@@ -48,7 +48,6 @@
 use Rector\Set\ValueObject\LevelSetList;
 use Rector\Set\ValueObject\SetList;
 use Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector;
-use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
 use Rector\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;
 use Rector\ValueObject\PhpVersion;
@@ -161,7 +160,6 @@
     $rectorConfig->rule(StringClassNameToClassConstantRector::class);
     $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
     $rectorConfig->rule(CompleteDynamicPropertiesRector::class);
-    $rectorConfig->rule(BooleanInIfConditionRuleFixerRector::class);
     $rectorConfig->rule(SingleInArrayToCompareRector::class);
     $rectorConfig->rule(VersionCompareFuncCallToConstantRector::class);
     $rectorConfig->rule(ExplicitBoolCompareRector::class);

src/Config/Services.php

@@ -13,11 +13,11 @@
 
 namespace CodeIgniter\Tasks\Config;
 
+use CodeIgniter\Config\BaseService;
 use CodeIgniter\Tasks\CronExpression;
 use CodeIgniter\Tasks\Scheduler;
-use Config\Services as BaseServices;
 
-class Services extends BaseServices
+class Services extends BaseService
 {
     /**
      * Returns the Task Scheduler

src/RunResolver.php

@@ -151,7 +151,7 @@ protected function isInList($value, string $list): bool
     {
         $list = explode(',', $list);
 
-        return in_array(trim($value), $list, true);
+        return in_array(trim((string) $value), $list, true);
     }
 
     /**

src/Task.php

@@ -365,7 +365,7 @@ protected function buildName()
      */
     public function __get(string $key)
     {
-        if ($key === 'name' && empty($this->name)) {
+        if ($key === 'name' && (! isset($this->name) || ($this->name === ''))) {
             return $this->buildName();
         }