Adding to check in if-else block in Python

Question

I have the following code;

if A:
    X = find()
else:
    X = find(all=True)

I need to add a new check - if C then find(amonut=C). In other words, the code would look like:

if A:
    if C:
         X = find(amount=C)
    else:
         X = find()
elif C:
    X = find(amount=C)
else:
    X = find(all=True)

It looks very ugly. Is there a better way to achieve the same behavior?

Dave · Accepted Answer · 2019-11-24 00:19:52Z

2

It looks to me that you find by amount "when C" irrespective of what A is, so make that the first thing to think about. Plus you can use elif to avoid deep nesting in this case:

if C:
     x = find(amount=C)
elif A:
     x = find()
else:
     x = find(all=True)

answered Nov 24, 2019 at 0:19

Dave

8,25811 gold badges55 silver badges101 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Hymns For Disco · Accepted Answer · 2019-11-24 00:06:49Z

1

if A and not C:
    X = find()
elif C:
    X = find(amount=C)
else:
    X = find(all=True)

answered Nov 24, 2019 at 0:06

Hymns For Disco

8,5052 gold badges26 silver badges42 bronze badges

Comments

DarrylG · Accepted Answer · 2019-11-24 00:26:16Z

1

Single line if/else

X = find(amount=C) if C else find() if A else find(all=True)

answered Nov 24, 2019 at 0:26

DarrylG

17.2k2 gold badges20 silver badges25 bronze badges

Comments

Siavoosh Ahmadpoorkhani · Accepted Answer · 2019-11-24 00:12:08Z

0

you can use Switcher instead of a bunch of if statements.

learn more about switcher

answered Nov 24, 2019 at 0:12

Siavoosh Ahmadpoorkhani

364 bronze badges

2 Comments

Dave Over a year ago

Providing the code demonstrating how it would be used for this case would improve this answer.

Siavoosh Ahmadpoorkhani Over a year ago

@Dave I agree with you. but in general, if statements could be converted to switcher only if they are trying to compare one argument with different values.

Collectives™ on Stack Overflow

Adding to check in if-else block in Python

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related